Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove invalid arch.s390x #16405

Merged
merged 1 commit into from
Dec 1, 2022
Merged

Remove invalid arch.s390x #16405

merged 1 commit into from
Dec 1, 2022

Conversation

llxia
Copy link
Contributor

@llxia llxia commented Dec 1, 2022

arch.s390x is invalid. We should use arch.390.
Since testJITServer is currently running and passing on zlinux,
update platformRequirements to avoid confusion.

Signed-off-by: Lan Xia Lan_Xia@ca.ibm.com

arch.s390x is invalid. We should use arch.390.
Since testJITServer is currently running and passing on zlinux,
update platformRequirements to avoid confusion.

Signed-off-by: Lan Xia <Lan_Xia@ca.ibm.com>
@llxia llxia added the comp:test label Dec 1, 2022
@llxia llxia requested a review from keithc-ca December 1, 2022 19:40
@@ -747,7 +747,7 @@
echo $(Q)$(TEST_JDK_BIN)$(D)jitserver doesn't exist; assuming this JDK does not support JITServer and trivially passing the test.$(Q); \
fi; \
$(TEST_STATUS)</command>
<platformRequirements>os.linux,^arch.arm,^arch.aarch64,^arch.s390x,bits.64</platformRequirements>
<platformRequirements>os.linux,^arch.arm,^arch.aarch64,bits.64</platformRequirements>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would seem that the intent of #10876 was only to enable this test on Power, but because there is no arch.s390x architecture, it was also enabled for arch.390, so this change seems safe.

@keithc-ca
Copy link
Contributor

This should not affect the platforms where the test runs; no need for a PR build.

@keithc-ca keithc-ca merged commit d0f1fb8 into eclipse-openj9:master Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants